Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added condition to accept bucketName. #3

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

Durgaprasad-Budhwani
Copy link
Contributor

Added condition to accept bucketName.

Example

myWebsite:
  component: "@serverless/website"
  inputs:
    bucketName: myBucket # (Optional) The Bucket name where `src` files/folder will be upload.
                         # If not provided, it will create random bucket name and upload `src` files

```
myWebsite:
  component: "@serverless/website"
  inputs:
    bucketName: myBucket # (Optional) The Bucket name where `src` files/folder will be upload.
                         # If not provided, it will create random bucket name and upload `src` files

```
Copy link
Member

@eahefnawy eahefnawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Durgaprasad-Budhwani ... I see the need for that, and I like that it's optional. LG2M

@eahefnawy eahefnawy merged commit 68b00c3 into serverless-components:master Aug 26, 2019
@Durgaprasad-Budhwani
Copy link
Contributor Author

Thanks, @eahefnawy for approving and merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants