Release 5.3.2 #582
Merged
Release 5.3.2 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ name: Node.js Package | |||
|
|
|||
| on: | |||
| release: | |||
| types: [created] | |||
| types: [published] | |||
There was a problem hiding this comment.
Changed to published since a draft release has a "Publish" button and a published event seems more logical.
|
Better check this instead v5.3.1...master |
|
@serverless-heaven/serverless-webpack-team @serverless-heaven/serverless-webpack-contributors |
j0k3r
approved these changes
Apr 30, 2020
|
I installed the master branch into a serverless stack. It deployed with no issues. I ran a regression test against it, and it passed. The build seems stable to me. |
|
We are also using the master branch without issue for now. |
jamesmbourne
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #545
How did you implement it:
Updated version for release.
How can we verify it:
Checkout the release branch and use it in a serverless deploy.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO