Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript example babel loader #527

Merged

Conversation

esetnik
Copy link
Contributor

@esetnik esetnik commented Jul 30, 2019

What did you implement:

Update typescript example to use babel-loader.

How did you implement it:

Use best practice webpack and babel config

How can we verify it:

Run ./node_modules/.bin/serverless invoke local -f goodbye --stage local

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain self-requested a review August 5, 2019 17:24
Copy link
Member

@HyperBrain HyperBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperBrain HyperBrain added this to the 5.3.2 milestone Aug 27, 2019
@HyperBrain HyperBrain merged commit 71c86c3 into serverless-heaven:master Aug 27, 2019
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
…ple-babel-loader

Typescript example babel loader
@miguel-a-calles-mba miguel-a-calles-mba mentioned this pull request Apr 29, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants