Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Images to img Directory #802

Merged
merged 3 commits into from Nov 17, 2020
Merged

Move Images to img Directory #802

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1305b6
Move images to img directory
rosborne132 Nov 16, 2020
a625f25
Fix typo
rosborne132 Nov 16, 2020
dc5ffd7
Remove typo fix
rosborne132 Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
@@ -1,6 +1,6 @@
# Serverless Next.js Component

![logo](./logo.gif)
![logo](./img/logo.gif)

[![serverless](http://public.serverless.com/badges/v3.svg)](https://www.serverless.com)
[![GitHub contributors](https://img.shields.io/github/contributors/serverless-nextjs/serverless-next.js)](https://github.com/serverless-nextjs/serverless-next.js/graphs/contributors)
Expand Down Expand Up @@ -381,7 +381,7 @@ myNextApplication:
apiLambda: "nodejs10.x"
```

Similarly, the timeout by default is 10 seconds. To customise you can:
Similarly, the timeout by default is 10 seconds. To customize you can:
Copy link
Collaborator

@dphang dphang Nov 16, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This is actually not a typo, as the original author of this package @danielcondemarin is based in the UK and these are the British spellings 😛.

I'm fine with reorganizing the images though, since there are a lot of files now in the repository root.


```yml
# serverless.yml
Expand Down Expand Up @@ -411,7 +411,7 @@ myNextApplication:

### Architecture

![architecture](./arch_no_grid.png)
![architecture](./img/arch_no_grid.png)

Four Cache Behaviours are created in CloudFront.

Expand All @@ -421,7 +421,7 @@ The third is associated to a lambda function which is responsible for handling t

1. Server side rendered page. Any page that defines `getInitialProps` method will be rendered at this level and the response is returned immediately to the user.

2. Statically optimised page. Requests to pages that were pre-compiled by next to HTML are forwarded to S3.
2. Statically optimized page. Requests to pages that were pre-compiled by next to HTML are forwarded to S3.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for optimised


3. Public resources. Requests to root level resources like `/robots.txt`, `/favicon.ico`, `/manifest.json`, etc. These are forwarded to S3.

Expand Down
0 arch.png → img/arch.png
View file
Open in desktop
File renamed without changes
0 arch_no_grid.png → img/arch_no_grid.png
View file
Open in desktop
File renamed without changes
0 logo.gif → img/logo.gif
View file
Open in desktop
File renamed without changes