Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): use 307 redirect for root -> locale URI instead … #886

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jan 25, 2021

…of rewrite

Related: #721

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #886 (d2f998d) into master (828b9dd) will decrease coverage by 0.00%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   80.37%   80.36%   -0.01%     
==========================================
  Files          64       64              
  Lines        2390     2394       +4     
  Branches      547      550       +3     
==========================================
+ Hits         1921     1924       +3     
- Misses        406      407       +1     
  Partials       63       63              
Impacted Files Coverage Δ
...ages/libs/lambda-at-edge/src/headers/addHeaders.ts 100.00% <ø> (ø)
...ckages/libs/lambda-at-edge/src/routing/rewriter.ts 100.00% <ø> (+1.96%) ⬆️
...ages/libs/lambda-at-edge/src/routing/redirector.ts 81.25% <87.50%> (+3.12%) ⬆️
...ackages/libs/lambda-at-edge/src/default-handler.ts 91.75% <100.00%> (-0.03%) ⬇️
...es/libs/lambda-at-edge/src/routing/locale-utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828b9dd...d2f998d. Read the comment docs.

@dphang dphang merged commit 98e963b into master Jan 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/locales branch January 25, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant