-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Babel setup #188
Add Babel setup #188
Conversation
@pmuens, I wonder if it would be more maintainable to have one higher level build setup for all of the components instead of a separate one for each. Each component needs its own |
Thank you for your review @brianneisler 👍 Yes, I actually wrote a bash script while working on this to add the scripts and the dependencies automatically since doing this manually for every component would've been a real pain. I thought along those lines but after thinking more about it I came up with the conclusion that every component should be self-contained since they might reside in other locations later on. Maybe that's a premature optimiation though. I'm open to other thoughts as well. |
ecdf36c
to
6e3e26a
Compare
ffaf292
to
af5d7d4
Compare
After spending a good portion of time on this PR we can finally see that all builds for all the supported Node.js versions (4 - 10) are finally green on Travis and AppVeyor. This PR can be considered done and needs a final review so that we can merge it |
imo we should spend some time manually testing this PR in different node environments before merging. Travis can sometimes be misleading. |
@pmuens Is there a specific reason we are holding off on merging this PR? Let me know. |
@ganeshvlrk no. No specific reason. I haven't tested the support for all the different Node.js versions (this would be a daunting task). IMHO seeing that the tests pass should be enough for now... |
Agreed. Let's go ahead and merge this on the basis of the tests passing |
@ganeshvlrk sounds good 👍 Can I just need an approval and we should be ready to merge this /cc @eahefnawy @brianneisler |
Just tested this today running it in a fresh Node 4 Docker container. Had to make some slight changes (e.g. Babel should be added to |
What has been implemented?
Adds a Babel setup for the components core and all components in the registry. Support is added for Node versions as early as 4. Travis and AppVeyor build matrices were updated as well.
Closes SC-16
Steps to verify
Run
npm run build
and / ornpm run watch
.Todos: