Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix files being omitted #577

Merged
merged 1 commit into from Apr 7, 2020
Merged

Fix files being omitted #577

merged 1 commit into from Apr 7, 2020

Conversation

ariataylor96
Copy link
Contributor

This is the updated version of this PR, to work with the new GA components.

The glob '**' would not match files such as [...file].js. This is critical for the NextJS component to utilize a catch-all API route, and breaks all deployments that try to use them.

Included files before PR:

.file.js
[file].js
file.js

Included files after PR:

.file.js
[...file].js
[file].js
file.js

@ac360 ac360 requested a review from eahefnawy April 7, 2020 01:04
@ac360
Copy link
Member

ac360 commented Apr 7, 2020

Thanks @markrawls. This appears important. @eahefnawy will look into this in a few hours.

@eahefnawy
Copy link
Member

Thanks @markrawls ... will release this asap! 🙌

@eahefnawy eahefnawy merged commit aa42aa6 into serverless:master Apr 7, 2020
@eahefnawy
Copy link
Member

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants