Fix files being omitted #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glob `'**'` would not match files such as `[...file].js`. Included files before PR: ``` .file.js [file].js file.js ``` Included files after PR: ``` .file.js [...file].js [file].js file.js ```
|
@eahefnawy Could this get merged please 🙏 It will allow supporting a pretty important feature in the next component. |
paleite
requested review from
agutoli,
anycodes,
billfine,
danielcondemarin,
dschep,
EwanValentine,
ganeshvlrk,
KnupMan,
laardee,
utx0,
medikoo,
xf10w and
pmuens
|
Upgrading globby to latest will also fix this. |
ariataylor96
approved these changes
Mar 20, 2020
This was referenced Apr 7, 2020
|
Hi, Could this get merged please 🙏 It will allow supporting a very important routing rule in the next component. [...file].js named file is not uploading to AWS lambda. |
Looks like it has been merged in another repo now (and the |
crash7
added a commit
to crash7/serverless
that referenced
this pull request
Aug 25, 2020
This ports a fix introduced in serverless-components: serverless-components/aws-lambda#26 but given some changes in the test, it probably needs to be flagged as a breaking change.
crash7
added a commit
to crash7/serverless
that referenced
this pull request
Aug 25, 2020
This ports a fix introduced in serverless-components: serverless-components/aws-lambda#26 but given some changes in the test, it probably needs to be flagged as a breaking change. Fixes serverless#8125
crash7
added a commit
to crash7/serverless
that referenced
this pull request
Aug 26, 2020
This ports a fix introduced in serverless-components: serverless-components/aws-lambda#26 but given some changes in the test, it probably needs to be flagged as a breaking change. Fixes serverless#8125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glob
'**'would not match files such as[...file].js.Included files before PR:
Included files after PR: