Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #5

Merged
merged 9 commits into from
Feb 16, 2018
Merged

Fix tests #5

merged 9 commits into from
Feb 16, 2018

Conversation

RaeesBhatti
Copy link
Contributor

No description provided.

@mthenw
Copy link
Contributor

mthenw commented Feb 15, 2018

@elsteelbrain any idea why TravisCI is not running?

@mthenw mthenw merged commit ce5f9bb into master Feb 16, 2018
@mthenw mthenw deleted the fixTests branch February 16, 2018 09:16
mthenw pushed a commit that referenced this pull request Feb 19, 2018
@p0wl
Copy link

p0wl commented Feb 20, 2018

why did you delete the "configure" function? The commit message "fix tests" does not really help...

@RaeesBhatti
Copy link
Contributor Author

I should've been more explicit in the messages but we decided to remove the configure method in another conversation.

@p0wl
Copy link

p0wl commented Feb 20, 2018

is that conversation public? I'm asking because I'm thinking if it is worth porting serverless/fdk#81 to event-gateway-sdk, but if you don't see value in such a functionality (as it is similar to configure), I won't do it.

@RaeesBhatti
Copy link
Contributor Author

The decision was made in a private conversation. @mthenw what is your opinion on this?

@mthenw
Copy link
Contributor

mthenw commented Feb 20, 2018

Hi @p0wl thanks for asking!

In general, because of how Event Gateway works right now there is no way to provide atomic operation allowing configuring multiple functions/subscriptions. That's why in some cases that would cause an inconsistent state in the EG comparing to what user defined. That's why we decided to fix it in the EG in the first place and then add configure method in SDK.

In general, the plan is allowing configuring whole space in one atomic operation in EG.

Let me know if you have more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants