Command for repeatable execution #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven in the params
|
hmm, I'm not sure why the tests are red. The failing tests do not seem related to my changes. Seems like the same tests failed in #80 as well. Master also seems to be red. |
|
Hey @p0wl, thanks for your interest and effort! Can I ask you to open an issue here at the Event Gateway SDK? https://github.com/serverless/event-gateway-sdk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for your awesome project. During the Event Gateway Workshop at JeffConf Hamburg on Thursday @pmuens introduced us to this project and we were wondering why the
configurecommand will fail when run with the same configuration multiple times.By looking at the code I figured that the
configurecommand actually only adds functions and subscriptions and even tries to add the given functions/subscriptions if they already exist.If Event Gateway would be used in a CI/CD scenario I think it would be very nice to have a command that can be executed at any time (multiple times) and just ensures that the configuration of the Event Gateway is set up as given. This way the actual configuration can be saved to a git repository and a build tool/service can just execute the given configuration on every build.
So I tried to introduce a
deploycommand (naming is hard, sorry. I choosedeploybecause it is used at serverless and basically has the same behaviour: only apply changes) and some tests.As I wanted to hear what the maintainers and users of fdk / Event Gateway think about this, I'll create this pull-request without documentation/... changes.
Let me know what you think!