Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 409 return status code to Config API resources (#465) #466

Merged
merged 5 commits into from
Jun 27, 2018

Conversation

baniol
Copy link
Contributor

@baniol baniol commented Jun 22, 2018

What did you implement:

Modified response status codes from 400 to 409 for POST requests for event types, functions, subscriptions and CORS configs resources. Updated unit tests and API docs accordingly.

How did you implement it:

How can we verify it:

Todos:

I'm not sure if a test for createSubscription in httpapi.go should be added in scope of the task

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@mthenw mthenw self-requested a review June 25, 2018 08:16
@mthenw
Copy link
Contributor

mthenw commented Jun 25, 2018

@baniol any idea why TravisCI is not running?

@baniol
Copy link
Contributor Author

baniol commented Jun 25, 2018

I have no idea why Travis is not running for this branch.

@mthenw
Copy link
Contributor

mthenw commented Jun 25, 2018

@baniol can you login to travisci.org and check if there is no need to accept some ToS or something?

@baniol
Copy link
Contributor Author

baniol commented Jun 25, 2018

I don't see anything like that in my account, unfortunately.
I checked https://travis-ci.org/serverless/event-gateway/requests, and I can see my PR failing with "Build type disabled via repository settings (pull_request)". Could this be related?

@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #466 into master will increase coverage by 1.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage    69.3%   70.78%   +1.47%     
==========================================
  Files          35       35              
  Lines        2163     2163              
==========================================
+ Hits         1499     1531      +32     
+ Misses        602      570      -32     
  Partials       62       62
Impacted Files Coverage Δ
httpapi/httpapi.go 90.47% <100%> (+7.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ba4a3...3d153fe. Read the comment docs.

@mthenw
Copy link
Contributor

mthenw commented Jun 25, 2018

@baniol oh, I see. I fixed that.

@mthenw
Copy link
Contributor

mthenw commented Jun 27, 2018

@baniol looks great.

@mthenw mthenw merged commit 5e02910 into serverless:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants