Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use alpine version to reduce vulnerabilities in image #51

Merged

Conversation

anandg112
Copy link
Contributor

@anandg112 anandg112 commented Mar 25, 2021

This PR uses alpine version of the image to reduce OS vulnerabilities in image. Scans were done using trivy image scanning - https://github.com/aquasecurity/trivy

cc @DavideViolante

From this:

nikolaik/python-nodejs:python3.9-nodejs14-slim (debian 10.8)
Total: 29 (HIGH: 21, CRITICAL: 8)

to:

nikolaik/python-nodejs:python3.9-nodejs14-alpine (alpine 3.13.2)
Total: 0 (HIGH: 0, CRITICAL: 0)

@tx0c
Copy link

tx0c commented Oct 7, 2021

this switch has caused Lambda build environment becomes a linuxmusl-x64 environment, caused some arch-dependent npm packages (like https://www.npmjs.com/package/sharp) installed wrong binaries, and then failed to run on Lambda, which requires linux-x64 binaries;

does here still maintain a debian slim based image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants