websockets: fix passing log group ARN

The log group ARN contains a trailing ":*" that seems to cause deployment to fail. Instead, generate the ARN with the trailing wildcard. fixes #6304
serverless · Jun 27, 2019 · 6b00ef5 · 6b00ef5
1 parent 9b9c9e2
commit 6b00ef5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/plugins/aws/package/compile/events/websockets/lib/stage.js b/lib/plugins/aws/package/compile/events/websockets/lib/stage.js
@@ -34,7 +34,7 @@ module.exports = {
       Object.assign(stageResource.Properties, {
         AccessLogSettings: {
           DestinationArn: {
-            'Fn::GetAtt': [logGroupLogicalId, 'Arn'],
+            'Fn::Sub': `arn:aws:logs:\${AWS::Region}:\${AWS::AccountId}:log-group:\${${logGroupLogicalId}}`,
           },
           Format: [
             '$context.identity.sourceIp',

diff --git a/lib/plugins/aws/package/compile/events/websockets/lib/stage.test.js b/lib/plugins/aws/package/compile/events/websockets/lib/stage.test.js
@@ -81,7 +81,8 @@ describe('#compileStage()', () => {
             Description: 'Serverless Websockets',
             AccessLogSettings: {
               DestinationArn: {
-                'Fn::GetAtt': [logGroupLogicalId, 'Arn'],
+                'Fn::Sub':
+                  'arn:aws:logs:${AWS::Region}:${AWS::AccountId}:log-group:${WebsocketsLogGroup}',
               },
               Format: [
                 '$context.identity.sourceIp',