Regression: Serverless 1.33 does not properly support integers as external values

[Jaystified]

This is a Bug Report

Description

• What went wrong?
  A logRetentionInDays should be an integer over 0 error interrupts deployment when the logRetentionInDays value is provided externally (in my case via a shell command)
• What did you expect should have happened?
  Externally provided integer is properly interpreted and deployment completes successfully.
• What was the config you used?
  Trying to deploy a 60-day expiration log retention lambda to AWS.
• What stacktrace or error message from your provider did you see?
  logRetentionInDays should be an integer over 0
  Node version is 8.10.0

Similar or dependent issues:
This forum post
This stackoverflow post
Not mine, but assuming same issue

Additional Data

• Serverless Framework Version you're using: 1.33.[0,1,2] (Error occurs in all three versions. 1.32 and earlier work as expected.)
• Operating System: Linux (Xubuntu 18.04)
• Stack Trace:
• Provider Error messages: logRetentionInDays should be an integer over 0

[dschep]

Could you provide the relevant parts of your serverless.yml please?

[Jaystified]

service: "issue"
provider:
  name: "aws"
  stage: "dev"
  logRetentionInDays: "${opt:logRetentionInDays, self:custom.defaultLogRetentionInDays}"
  runtime: "nodejs8.10"
functions:
  hello:
    handler: "handler.hello"
    events: []
plugins: []
package:
  artifact: "../../target/lambda.zip"
custom:
  defaultLogRetentionInDays: 14

[dschep]

Ah.. What if you do:

  logRetentionInDays: ${opt:logRetentionInDays, self:custom.defaultLogRetentionInDays}

(remove the quotes)

[dschep]

Tho I wouldn't expect ${opt:logRetentionInDays} to work 😞 I'm not sure how this is dealt with for other options that must be integers. IMO because of the ${opt:adsflajdf} feature (and other variable sources like SSM) it makes sense to attempt to cast values to the right type. Thoughts @pmuens @eahefnawy @horike37?

[Jaystified]

Confirming that removing the quotes does not change the outcome.

Was the ${opt:adsflajdf} feature modified in 1.33?

[dschep]

does logRetentionInDays: ${self:custom.defaultLogRetentionInDays} alone with an integer at custom.defaultLogRetentionInDays work? I don't think the opt option has ever coerced values to different types :/

[Jaystified]

Yes, ${self:custom.defaultLogRetentionInDays} alone does work (as does the full line when the var isn't provided).
Since the original serverless.yml did work as-is in previous versions, the variables were coerced somehow at some point :\

[dschep]

Thanks for the details @Jaystified