Replace lodash utility with String native methods #7715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
suggested changes
May 11, 2020
| @@ -13,7 +12,7 @@ module.exports = { | |||
| path.join(this.serverless.config.servicePath || '.', '.serverless'); | |||
|
|
|||
| // Only move the artifacts if it was requested by the user | |||
| if (this.serverless.config.servicePath && !_.endsWith(packagePath, '.serverless')) { | |||
| if (this.serverless.config.servicePath && packagePath.endsWith('.serverless')) { | |||
There was a problem hiding this comment.
If I see correctly negation was lost
There was a problem hiding this comment.
Fixed and squashed commits.
| @@ -36,7 +35,7 @@ module.exports = { | |||
| path.join(this.serverless.config.servicePath || '.', '.serverless'); | |||
|
|
|||
| // Only move the artifacts if it was requested by the user | |||
| if (this.serverless.config.servicePath && !_.endsWith(packagePath, '.serverless')) { | |||
| if (this.serverless.config.servicePath && packagePath.endsWith('.serverless')) { | |||
There was a problem hiding this comment.
Fixed and squashed commits.
exoego
force-pushed
the
string-native-methods
branch
from
6ce59aa
to
a2f3e98
Compare
Codecov Report
@@ Coverage Diff @@
## master #7715 +/- ##
==========================================
- Coverage 88.00% 87.99% -0.02%
==========================================
Files 245 245
Lines 9202 9201 -1
==========================================
- Hits 8098 8096 -2
- Misses 1104 1105 +1
Continue to review full report at Codecov.
|
|
@exoego is this ready to take? If so, please re-request review. Thank you! |
|
Ready to re-review. |
medikoo
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7680 (comment)
Let's minimize lodash dependency where native ways are available.
require('lodash.pick'))