Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS Websocket): Add ability to configure log format and types #10956

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

Ariette
Copy link
Contributor

@Ariette Ariette commented Apr 11, 2022

Addresses: #6218
Also related to #6578 and #7836

The PR adds accessLogging, executionLogging, fullExecutionData, and format options to websocket log configuration, which only provides the level option now.
By that, you can configure websocket log just like restApi log.

# serverless.yml
provider:
  name: aws
  logs:
    websocket:
      level: INFO
      fullExecutionData: false

It's more like a bug fix rather than feature improvement, becuase it just implements what the documentation describes.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #10956 (559c457) into main (23a5ea3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #10956      +/-   ##
==========================================
+ Coverage   86.38%   86.40%   +0.02%     
==========================================
  Files         305      305              
  Lines       12947    12959      +12     
==========================================
+ Hits        11184    11197      +13     
+ Misses       1763     1762       -1     
Impacted Files Coverage Δ
lib/plugins/aws/provider.js 94.59% <ø> (ø)
...aws/package/compile/events/websockets/lib/stage.js 100.00% <100.00%> (ø)
...ackage/compile/events/websockets/lib/deployment.js 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a5ea3...559c457. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ariette - I have a few questions, please see my comments

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Ariette - it looks great overall, it would be great to mention it in documentation and I also spotted one minor potential improvement, let me know what do you think

@Ariette Ariette requested a review from pgrzesik April 13, 2022 01:37
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ariette - it looks great - let's confirm with @mnapoli that everything looks good from his perspective and we'll be good to go 👍

@pgrzesik pgrzesik requested a review from mnapoli April 13, 2022 10:33
@pgrzesik pgrzesik changed the title Add ability to configure more options of websocket log feat(AWS Websocket): Add ability to configure log format and types Apr 14, 2022
@pgrzesik pgrzesik merged commit 82ce1c8 into serverless:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants