-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AWS Websocket): Add ability to configure log format and types #10956
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10956 +/- ##
==========================================
+ Coverage 86.38% 86.40% +0.02%
==========================================
Files 305 305
Lines 12947 12959 +12
==========================================
+ Hits 11184 11197 +13
+ Misses 1763 1762 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ariette - I have a few questions, please see my comments
test/unit/lib/plugins/aws/package/compile/events/websockets/lib/stage.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Ariette - it looks great overall, it would be great to mention it in documentation and I also spotted one minor potential improvement, let me know what do you think
test/unit/lib/plugins/aws/package/compile/events/websockets/lib/stage.test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses: #6218
Also related to #6578 and #7836
The PR adds
accessLogging
,executionLogging
,fullExecutionData
, andformat
options to websocket log configuration, which only provides thelevel
option now.By that, you can configure websocket log just like restApi log.
It's more like a bug fix rather than feature improvement, becuase it just implements what the documentation describes.