Bug: CLI does not handle options with value of zero correctly #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stevecaldwell77 , thanks for the contribution, but we've stopped working on 0.5 of Serverless at this point to fully focus on the next release with V1 that we're currently working on. Therefore we're not taking any commits for 0.5 at this point and I'm closing this PR. We only have a limited set of resources and just need to make sure we're putting everything we have into our next release (and can provide great long term support and backwards compatibility from then on). Hope you understand. We would love to get your feedback on V1 of the framework and I'm happy to walk you through any questions to make sure its all working great for you. |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI option parsing code did a truthy test to determine whether a user provided a value for an option. This meant that values of 0 were being ignored. This is an issue in particular for serverless-autoprune-plugin:
arabold/serverless-autoprune-plugin#3
This PR fixes the bug by doing an explicit null/undefined check instead.