Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct exit code for failed function invocation #2836

Closed
wants to merge 199 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
199 commits
Select commit Hold shift + click to select a range
e724b81
adding replaceAll to turn any escaped single quotes back to regular s…
Nov 27, 2016
5a1539f
Fix #2784 - slstats error
paulofla Nov 27, 2016
665400e
fix #2784 - fixing lint errors
paulofla Nov 27, 2016
edd923f
fix bug in event source mapping with custom IAM role
Nov 28, 2016
0e274d4
Add support for directories in url of install command
horike37 Nov 28, 2016
c7c3218
remove request and response config when using proxy integration
dougmoscrop Nov 26, 2016
b05cac7
Add core metrics plugin
pmuens Nov 29, 2016
83900b3
Add AwsMetrics plugin
pmuens Nov 29, 2016
ba27669
Add plugins to Plugins.json file
pmuens Nov 29, 2016
2f4b510
Add documentation
pmuens Nov 29, 2016
80b12f6
Add automatic Period setting and remove period option
pmuens Nov 29, 2016
f249fa1
Fix typo in test description
pmuens Nov 29, 2016
628a55e
Add translation of human friendly startTime syntax
pmuens Dec 1, 2016
45b6695
Update docs about startTime and endTime
pmuens Dec 1, 2016
5994360
Update tests for default value setting of startTime and endTime
pmuens Dec 1, 2016
d074078
Update documentation for default valued of startTime and endTime
pmuens Dec 1, 2016
af35ee3
add init command for easy onboarding
ac360 Sep 18, 2016
3814837
fix tests
ac360 Sep 18, 2016
42ee9eb
fix linting issues
ac360 Sep 18, 2016
efdbe2a
fix linting error
ac360 Sep 18, 2016
693fceb
remove unused dependency
ac360 Sep 19, 2016
da19c9e
add support for setting multiple profiles
ac360 Sep 19, 2016
08769fc
fix linting errors
ac360 Sep 19, 2016
db23598
fix linting error
ac360 Sep 19, 2016
6cbe7d8
Rename from init to setup
pmuens Nov 23, 2016
88ce330
Split up setup into two plugins
pmuens Nov 23, 2016
3377108
Add validation and test coverage for setup plugin
pmuens Nov 23, 2016
ce82aae
Add tests for constructor of AwsSetup
pmuens Nov 23, 2016
114f54e
Minor refactorings
pmuens Nov 24, 2016
1bfa6a9
Add tests for setupAws() method
pmuens Nov 24, 2016
f6b7dd7
Add documentation
pmuens Nov 24, 2016
eaef9e6
Add link to CLI command in main docs README.md file
pmuens Nov 24, 2016
38e5f3f
Correct exit code for failed function invocation
JoeStanton Dec 1, 2016
f36c119
Change plugin structure from „setup“ to „config credentials“
pmuens Dec 1, 2016
0baf2eb
Update documentation to use the new „config credentials“ commands
pmuens Dec 1, 2016
5e4ad45
Fix date parsing bug
pmuens Dec 1, 2016
5ffd70e
Fix comment
pmuens Dec 1, 2016
9fc5dc8
update lifecycle event
nikgraf Dec 1, 2016
29cdbd6
fix missing lifecycle updates
nikgraf Dec 1, 2016
a949cd9
Merge pull request #2160 from serverless/init-command
nikgraf Dec 1, 2016
e439587
add Support for resources as an array
dougmoscrop Dec 2, 2016
031841e
Updates according to PR review
pmuens Dec 2, 2016
ca5b9e1
fix returning error from local invocation
Dec 2, 2016
b708f66
Merge pull request #2819 from serverless/add-metrics-plugin
nikgraf Dec 2, 2016
21ef1cd
Reject promise and handle exit code in the wrapper
JoeStanton Dec 2, 2016
5ddd8d7
remove the lifecycle event from config to hide it in the command list
nikgraf Dec 2, 2016
23f3f59
Merge pull request #2847 from serverless/hide-config
nikgraf Dec 2, 2016
d376c69
Refactor codebase to make it easier to understand
pmuens Nov 25, 2016
12161f2
Add metric retrieval (invocations, throttles, errors and duration) an…
pmuens Nov 25, 2016
e06364b
Remove x after invocations and throttles messages
pmuens Nov 28, 2016
3410b75
Refactor info plugin and add tests
pmuens Nov 28, 2016
06a103e
Add documentation
pmuens Nov 28, 2016
8d4ce41
Add dot at the end of average abbreviation
pmuens Nov 28, 2016
ebd4286
Fix test descriptions
pmuens Nov 29, 2016
f4ddd0a
bump version to 1.3.0
eahefnawy Dec 2, 2016
1ca5a32
1.3 shrinkwrap
eahefnawy Dec 2, 2016
f7f15bb
Remove metrics fetching from info plugin
pmuens Dec 2, 2016
5ab3a62
Merge pull request #2850 from serverless/1.3-version-bump
eahefnawy Dec 2, 2016
e581f03
update CHANGELOG.md
Dec 2, 2016
4ff35d7
Merge pull request #2851 from serverless/changelog-update
mthenw Dec 2, 2016
189843c
Fix the --timestamp parameter description
brunobelotti Dec 2, 2016
b494005
fix setting exit code
Dec 2, 2016
ade4684
Merge pull request #2852 from brunobelotti/patch-1
mthenw Dec 2, 2016
63787df
Merge pull request #2845 from serverless/fix-local-invoke-error
mthenw Dec 2, 2016
e08af13
Fixed issues pointed out
horike37 Dec 3, 2016
92d4a2a
add the test conde
horike37 Dec 3, 2016
c927e34
fixed the docs
horike37 Dec 4, 2016
b69790e
Adding named IAM capability to initial stack creation
surfacedstudio Dec 4, 2016
cf2f7f1
add integration test for deploying with --noDeploy flag
laardee Dec 4, 2016
75e610c
Fixed unit test
surfacedstudio Dec 4, 2016
20e0520
Linting fixes
surfacedstudio Dec 4, 2016
1f2f3ad
Update displaying of function ARNs
pmuens Dec 5, 2016
3710740
fixed typo
horike37 Dec 5, 2016
45ec9eb
update shrinkwrap with production only packages
Dec 5, 2016
67f9603
Merge pull request #2859 from serverless/update-shrinkwrap
pmuens Dec 5, 2016
8ee9884
Update RELEASE_CHECKLIST.md file
pmuens Dec 5, 2016
2fc8aa1
Merge pull request #2860 from serverless/update-release-checklist
pmuens Dec 5, 2016
945e091
Merge pull request #2854 from surfacedstudio/features/add-named-iam-c…
mthenw Dec 5, 2016
da3356b
Rename provider name from 'ibm' to 'openwhisk'.
Dec 5, 2016
7eb9335
add doc generation dep
DavidWells Dec 5, 2016
c5c910d
add transform function to keep plugins up to date
DavidWells Dec 5, 2016
4a718b6
update plugin list pulling from plugin repo
DavidWells Dec 5, 2016
1f1b8a9
fix linting
DavidWells Dec 5, 2016
829a8a5
update linting
DavidWells Dec 5, 2016
afd8397
fix linting.... ⊂◉‿◉つ
DavidWells Dec 5, 2016
e46a236
add agent for serverless context
DavidWells Dec 6, 2016
28c4135
fix lint ⊂◉‿◉つ
DavidWells Dec 6, 2016
5c480d1
change to userAgent
DavidWells Dec 6, 2016
1e2e196
Merge pull request #2870 from serverless/updateSegment
pmuens Dec 6, 2016
c9d2faf
add a dotnet core csharp template
jimmyp Dec 4, 2016
c58ccd5
fix naming, changed from aws-dotnet-csharp to aws-csharp
jimmyp Dec 5, 2016
7f46bbf
add unit test for create csharp
jimmyp Dec 5, 2016
b667d6d
add hello world documentation for csharp template
jimmyp Dec 5, 2016
cc8bd58
fix copy pasta errors in helloworld csharp doco
jimmyp Dec 6, 2016
31682f9
add aws-csharp to aws cli create doco
jimmyp Dec 6, 2016
74a0c4d
Missing indentation for Fn::Join params
sime Dec 6, 2016
486df0c
simplified the IAM role check + added tests
Dec 6, 2016
609632c
Merge pull request #2874 from sime/patch-1
pmuens Dec 6, 2016
ada411f
add aws-csharp to services.md doco
jimmyp Dec 6, 2016
6bf53ab
Add detection of Jenkins
pmuens Dec 7, 2016
6743df4
Merge pull request #2866 from jthomas/master
pmuens Dec 7, 2016
f8dc248
added default lambda env vars to local invoke
eahefnawy Dec 5, 2016
9bcde02
lowercase MemorySize in invoke local
eahefnawy Dec 7, 2016
1395eaa
reverted change in formating as some people parse it
nikgraf Dec 7, 2016
bcecad3
Merge branch 'master' into add-metrics-to-info-plugin
nikgraf Dec 7, 2016
5ddaded
fix tests
nikgraf Dec 7, 2016
343439f
removed double default region setting
eahefnawy Dec 7, 2016
0657f48
Merge pull request #2881 from serverless/add-detection-of-jenkins
mthenw Dec 7, 2016
1b5f25a
consitent code style in display
nikgraf Dec 7, 2016
1f2fd1b
Update warning message
pmuens Dec 7, 2016
6ddc705
Merge pull request #2794 from serverless/add-metrics-to-info-plugin
pmuens Dec 7, 2016
570d23d
Merge pull request #2799 from dougmoscrop/fix_proxy_parameters
mthenw Dec 7, 2016
a4be376
updates invoke local test
eahefnawy Dec 7, 2016
79874bd
rename directory
nikgraf Dec 7, 2016
57246fd
cleanup package test and add it to integration testsuite
nikgraf Dec 7, 2016
d41b733
simplify test
nikgraf Dec 7, 2016
f58f133
Merge pull request #2865 from serverless/invoke-local-env-var
mthenw Dec 7, 2016
fd33f98
Merge pull request #2855 from laardee/2739-nodeploy-integration-test
nikgraf Dec 7, 2016
fd4c6e9
Missing escapes for backslashes required in VTL template
Dec 7, 2016
dbb50b1
add prepublish script
DavidWells Dec 8, 2016
bdca0b9
update script
DavidWells Dec 8, 2016
8603144
add examples auto generate snippet
DavidWells Dec 8, 2016
ff6f2ec
add community examples
DavidWells Dec 8, 2016
52f5296
fix readme formatting
DavidWells Dec 8, 2016
2b04cac
update doc tables
DavidWells Dec 8, 2016
404c56d
update readme with fancy tables ⊂◉‿◉つ
DavidWells Dec 8, 2016
936ba11
update readme
DavidWells Dec 8, 2016
625be97
linter....... ⊂◉‿◉つ
DavidWells Dec 8, 2016
45b4f86
travisss!
DavidWells Dec 8, 2016
7cf4425
remove prepublish because travis breaks
DavidWells Dec 8, 2016
0ed6513
Merge pull request #2868 from serverless/addBetterPluginList
DavidWells Dec 8, 2016
e611e4b
Fix linting error
pmuens Dec 8, 2016
cb9f818
Merge pull request #2808 from evilantnie/master
pmuens Dec 8, 2016
adea45e
Temporarily remove provider.variableSyntax during variable population
johncmckim Dec 8, 2016
197e989
Fix credentials setup bug
pmuens Dec 8, 2016
5a978af
add support for stdin in invoke command
Nov 30, 2016
84fdbd3
Merge pull request #2893 from serverless/fix-credentials-setup-bug
mthenw Dec 8, 2016
b78f7ac
remove duplicated tests
Dec 8, 2016
ab6d5c4
Merge pull request #2894 from serverless/add-stdin
mthenw Dec 8, 2016
b6683d9
Merge pull request #2842 from dougmoscrop/array_resources
pmuens Dec 8, 2016
75f7fe7
rename example page
Dec 8, 2016
dc1ba7d
Merge pull request #2863 from jimmyp/csharp_dotnetcore_template
mthenw Dec 8, 2016
3ab58d4
Merge pull request #2891 from johncmckim/issue-2890
eahefnawy Dec 8, 2016
24ad264
add examples to links
ac360 Dec 8, 2016
80daa32
remove build script for csharp example
Dec 8, 2016
fe42d33
Tiny typo
pizza Dec 8, 2016
7a23cba
Merge pull request #2896 from serverless/cleanup-csharp
mthenw Dec 8, 2016
164c720
Merge pull request #2897 from pizza/patch-1
pmuens Dec 8, 2016
2a79fed
add other examples
DavidWells Dec 8, 2016
82cfc21
update hello world readme
DavidWells Dec 8, 2016
1ac5b72
delete examples that moved to examples/examples repo
DavidWells Dec 8, 2016
c3a7a33
fixed the flow of processing
horike37 Dec 9, 2016
55e0d54
Merge pull request #2899 from serverless/updateExamples
pmuens Dec 9, 2016
5e62370
Merge pull request #2809 from paulofla/slstatsfix
pmuens Dec 9, 2016
818c824
Merge pull request #2814 from PetrKohut/fixed-event-source-mapping-wi…
pmuens Dec 9, 2016
ac92c2e
Fix tests and add some minor fixes
pmuens Dec 9, 2016
c3091f9
update example link
mthenw Dec 9, 2016
e5eec0f
Merge pull request #2816 from horike37/issue-2721
mthenw Dec 9, 2016
c0a83ee
Upgrade AWS SDK shrinkwrap version
sime Dec 9, 2016
0acaaa0
Merge pull request #2904 from sime/aws-sdk-update
mthenw Dec 9, 2016
0141456
Update incorrect text for example
pmuens Dec 9, 2016
328c3f5
Merge pull request #2908 from serverless/fix-install-docs
pmuens Dec 9, 2016
ee19ce6
add serverless.yml to table of contents
ac360 Dec 10, 2016
fdb5407
Add CloudWatchEvent rule name and description fields
horike37 Dec 10, 2016
0ff6761
fix aws metrics plugin lint issues
laardee Dec 11, 2016
4c96e20
Merge pull request #2915 from laardee/fix-aws-metrics-plugin-lint
pmuens Dec 11, 2016
720e41e
update aws-sdk version
Dec 9, 2016
ca1c6de
Merge pull request #2905 from serverless/update-aws-sdk
pmuens Dec 11, 2016
ed1a674
Merge branch 'master' into issue-2832
pmuens Dec 12, 2016
7067680
fixed the docs
horike37 Dec 12, 2016
45ac811
Merge branch 'issue-2832' of github.com:horike37/serverless into issu…
horike37 Dec 12, 2016
9686a92
fixed typo
horike37 Dec 12, 2016
e2f5c06
Merge pull request #2910 from horike37/issue-2832
mthenw Dec 12, 2016
441ae76
Fix order of CLI docs
pmuens Dec 12, 2016
dfac939
Merge pull request #2920 from serverless/fix-order-of-cli-docs
pmuens Dec 12, 2016
577f379
added a note about deploying function versions
eahefnawy Dec 12, 2016
c27e01f
separate commands into separate pages
ac360 Dec 13, 2016
c41a39c
Merge pull request #2926 from serverless/doc-updates
ac360 Dec 13, 2016
4ffa47f
Merge pull request #2923 from serverless/eahefnawy-patch-1
eahefnawy Dec 13, 2016
5e9116d
Add service wide metrics support
pmuens Dec 12, 2016
fd03e55
Split up config CLI doc
pmuens Dec 13, 2016
cf18127
Merge pull request #2927 from serverless/split-up-config-cli-doc
pmuens Dec 13, 2016
142946e
fixed bug where you can now invoke without any input data
eahefnawy Dec 13, 2016
08009c2
handling strings
eahefnawy Dec 13, 2016
cee63f1
Merge pull request #2928 from serverless/invoke-stdin-bug
eahefnawy Dec 13, 2016
df8997e
Update examples with more "real world" dates
pmuens Dec 13, 2016
a8540b3
Refactor functions into reusable util functions
pmuens Dec 13, 2016
443865f
Remove utils file and move helper functions into class file
pmuens Dec 13, 2016
007be3d
Merge pull request #2922 from serverless/add-service-wide-metrics-sup…
mthenw Dec 13, 2016
52de4e6
update csharp example
Dec 13, 2016
e069536
Fix stdin docs for invoke
pmuens Dec 13, 2016
0a032f4
Merge pull request #2932 from serverless/update-csharp
mthenw Dec 13, 2016
2bdb312
Merge pull request #2933 from serverless/fix-stdin-docs-for-invoke
pmuens Dec 13, 2016
876c1d8
Update apigateway.md
nicka Dec 13, 2016
cde9c2d
Updating section on AWS pricing
TheMcMurder Dec 13, 2016
16ac810
Merge pull request #2934 from nicka/patch-3
pmuens Dec 14, 2016
ed591ff
Merge pull request #2935 from TheMcMurder/patch-1
pmuens Dec 14, 2016
c55a3af
Merge branch 'invoke-exit-code' of https://github.com/redbadger/serve…
Dec 14, 2016
be06c47
fix lint errors
Dec 14, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion bin/serverless
Expand Up @@ -17,4 +17,7 @@ process.noDeprecation = true;
});

return serverless.init().then(() => serverless.run());
}).catch(e => logError(e)))();
}).catch(e => {
process.exitCode = 1;
logError(e);
}))();
4 changes: 4 additions & 0 deletions lib/plugins/aws/invoke/index.js
Expand Up @@ -108,6 +108,10 @@ class AwsInvoke {
logResult.split('\n').forEach(line => this.consoleLog(formatLambdaLogEvent(line)));
}

if (invocationReply.FunctionError) {
return BbPromise.reject(new Error("Invoked function errored"));
}

return BbPromise.resolve();
}

Expand Down
18 changes: 18 additions & 0 deletions lib/plugins/aws/invoke/index.test.js
Expand Up @@ -260,5 +260,23 @@ describe('AwsInvoke', () => {

return awsInvoke.log(invocationReplyMock);
});

it('rejects the promise for failed invocations', (done) => {
const invocationReplyMock = {
Payload: `
{
"testProp": "testValue"
}
`,
LogResult: 'test',
FunctionError: true,
};

awsInvoke.log(invocationReplyMock).then(p => {
done(new Error("Promise resolved"));
}, (e) => {
done()
});
});
});
});