Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct exit code for failed function invocation #2836

Closed
wants to merge 199 commits into from

Conversation

JoeStanton
Copy link
Contributor

@JoeStanton JoeStanton commented Dec 1, 2016

What did you implement:

Exit with a status code that reflects the success/failure of the invoked Lambda function. This is useful when sls invoke is used as part of a shell script.

I'm not sure if there's a better place for this logic?

Todos:

  • Write tests
  • Write documentation (N/A)
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config/commands/resources (sls invoke <x>)
  • Enable "Allow edits from maintainers" for this PR
  • Change ready for review message below

Is this ready for review?: YES

mthenw and others added 27 commits December 12, 2016 10:28
Add CloudWatchEvent rule name and description fields
separate commands into separate pages
added a note about deploying function versions
fixed bug where you can now invoke without any input data
…etrics-support

Add service wide metrics support
Lambda has been moved to have it's own permanent free tier. It is no longer part of the Expiring offers.
@mthenw
Copy link
Contributor

mthenw commented Dec 14, 2016

Ups. I pushed to wrong branch. Sorry for that :/ I will create separate PR with @JoeStanton commits cherry-picked.

@mthenw mthenw closed this Dec 14, 2016
@mthenw mthenw mentioned this pull request Dec 14, 2016
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet