Corrected Access-Control-Allow-Methods for ANY HTTP events #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Access-Control-Allow-Methods OPTIONS response header for ANY http verb requests now correctly includes all HTTP verbs.
arabold
reviewed
Mar 2, 2017
| @@ -19,6 +19,11 @@ module.exports = { | |||
| 'Access-Control-Allow-Credentials': `'${config.allowCredentials}'`, | |||
| }; | |||
|
|
|||
| if(config.methods.indexOf('ANY') > -1){ | |||
There was a problem hiding this comment.
I suggest to use _.includes(config.methods, 'ANY') instead as it's clearer.
|
I have updated the PR as per your suggestion. |
|
@jmannau Thanks for this fix! 👍 ... Could you please fix the linting issues so that the build passes and we can merge it? |
|
just ran into this issue too, thanks @jmannau! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Access-Control-Allow-Methods OPTIONS response header for ANY http
verb requests now correctly includes all HTTP verbs.
What did you implement:
Closes #3303
How did you implement it:
This PR checks if the methods array includes the
ANYverb. If so, it replaces the unrecognisedANYmethod in theAccess-Control-Allow-Methodsheader with the correct HTTP verbs'DELETE,GET,HEAD,PATCH,POST,PUT'.How can we verify it:
The appropriate tests have been updated to include the ANY method.
-->
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO