New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add significant variable usage corner cases #4529

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
3 participants
@erikerikson
Member

erikerikson commented Dec 5, 2017

What did you implement:

Add tests to ongoingly verify the cases addressed by issues #3627, #3740, #3711, and #3882
For augmenting #4144

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

expect(result.custom).to.eql(expected);
})).to.be.fulfilled;
});
// // REGARDING THESE CASES, SEE:

This comment has been minimized.

@HyperBrain

HyperBrain Dec 6, 2017

Member

As discussed, the comments to disable these tests for now are ok here 😃

@HyperBrain HyperBrain merged commit bf7bbe0 into serverless:circular-vars Dec 6, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 87.809%
Details

@pmuens pmuens added this to the 1.25 milestone Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment