Create plugin: Bump NodeJS runtime version to 8.10 #5103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
horike37
suggested changes
Aug 13, 2018
| @@ -17,7 +17,7 @@ service: capitalize | |||
|
|
|||
| provider: | |||
| name: kubeless | |||
| runtime: nodejs6 | |||
| runtime: nodejs8.10 | |||
There was a problem hiding this comment.
This is for kubeless, not AWS. Is this correct?
| @@ -21,7 +21,7 @@ provider: | |||
|
|
|||
| functions: | |||
| hello: | |||
| runtime: nodejs8.3 | |||
| runtime: nodejs8.10 | |||
There was a problem hiding this comment.
Same here. This is for Spotinst.
|
Thanks for taking the time and working on this @RaeesBhatti 👍 I'll close this for now since it's a stale PR and there are still some unaddressed issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
I changed the NodeJS runtime version to 8.10 in all templates.
How did you implement it:
Changed the
provider.runtimeproperty tonodejs8.10How can we verify it:
(path to serverless bin of this repository) create --template aws-nodejs-ecma-scriptand change any of the handlers to use NodeJS 8 features (e.g. async/await)Todos:
Is this ready for review?: YES
Is it a breaking change?: NO