releasing v1.33.0 #5482
Merged
releasing v1.33.0 #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschep
force-pushed
the
release-v-1-33-0
branch
2 times, most recently
from
5e5ebc9
to
eb85565
Compare
|
So excited for this release thanks for making this happen! |
horike37
reviewed
Nov 14, 2018
dschep
force-pushed
the
release-v-1-33-0
branch
2 times, most recently
from
d4f317a
to
a3adba9
Compare
dschep
force-pushed
the
release-v-1-33-0
branch
from
a3adba9
to
49abc61
Compare
|
@pmuens @eahefnawy @horike37, are not all |
pmuens
approved these changes
Nov 15, 2018
|
Great. Yeah, all the simple ones pass. And actually 1 more complex tests passed for me than on v1.32.0 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also modified the prs since release script to correctly get the most recent tag, grab PR descriptions from github's API, & modified its out put to be able to go straight into the changelog!
And added a step to the release process to update the docs since I changed them to not point to master to avoid issues like #5479