Remove platform code #5687
Merged
Remove platform code #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschep
approved these changes
Jan 17, 2019
| @@ -3,7 +3,6 @@ title: Serverless Framework Documentation | |||
| menuText: Docs | |||
| layout: Doc | |||
| menuItems: | |||
| - {menuText: Getting Started, path: /framework/docs/getting-started/} | |||
There was a problem hiding this comment.
Any particular reason for removing this?
There was a problem hiding this comment.
Yes, it is a duplicate. The docs ALSO create links for each file in the dir. Since there is a getting-started.md file as well as this metadata link, this resulted in duplicate links on our docs site.
|
Nope. Good catch @exoego ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Removed the Serverless Platform code from the Framework.
Is this ready for review?: NO
Is it a breaking change?: NO