Join GitHub today
Append in Custom Syntax #5799
What did you implement:
Respect custom variable syntaxes when appending to deep variables.
How did you implement it:
How can we verify it:
See new unit test. For manual confirmation, run
serverless.yml - Errorneous template with a custom variable syntax
Is this ready for review?: YES
referenced this pull request
Feb 6, 2019
pmuens left a comment
Great stuff! Just tried it and it works fine
Great job @erikerikson
I haven't tested other variables usages thoroughly. Is there a huge likelyhood that this could break existing variables usages? The surface area of this change seems quite small and our Serverless Varaibles test coverage looks decent enough. Just asking since you and @eahefnawy are the Serverless Variables experts
If that's not the case I'd say it should be GTM
This is much more of a unhandled corner case that is now properly covered.
One of the big efforts I've made in the variables as part of my contribution is a large expansion of user level variable behavior specifications via tests. To be honest, mostly because I lost trust in my ability to reason over the effects of changes in the test could be complete and thorough, so every time there's a bug I've added coverage to make sure it doesn't crop back up. You can see the section around where I've added the test in this PR to see what I mean.