Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: exclude development dependency files when packaging functions #6137

Merged
merged 1 commit into from
May 15, 2019

Conversation

mydiemho
Copy link
Contributor

@mydiemho mydiemho commented May 14, 2019

.funcignore is not being used so have to add the ignore files
to the exclude section in serverless.yml

What did you implement:

Update azure-nodejs/serverless.yml to exclude vscode settings and local.settings.json in function artifact.

How did you implement it:

How can we verify it:

sls create -t azure-nodejs -p myApp
cd myApp
npm install
sls deploy # verify that those files are not uploaded to the app

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

.funcignore is not being used so have to add the ignore files
to the `exclude` section in serverless.yml
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Thanks @mydiemho. LGTM :shipit:

@pmuens pmuens merged commit ccd073c into serverless:master May 15, 2019
@pmuens pmuens changed the title azure: exclude development dependency files when packaging functions Azure: exclude development dependency files when packaging functions May 15, 2019
@mydiemho mydiemho deleted the ignoreDevelopmentDependency branch May 20, 2019 22:17
@medikoo medikoo removed this from the 1.45.0 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants