Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve ESlint config #6188

Merged
merged 6 commits into from
May 29, 2019
Merged

Fix and improve ESlint config #6188

merged 6 commits into from
May 29, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 29, 2019

It's about basic fixes and improvements (as otherwise bigger refactor into serverless projects common config is pending)

  • Fix parsing option, with so far setting ESLint treated our modules as ESM, and disallowed certain syntax which is perfectly valid in CJS
  • Fix configuration of strict rule, so it correctly enforces usage of 'use strict' (having that, fixed few modules in which it was missing)
  • Turn on prefer-rest-aparams rule (and fixed few modules which didn't obey)
  • Configure import/no-extraneous-dependencies rules, so it works for us.

Is this ready for review?: YES
Is it a breaking change?: NO

@medikoo medikoo self-assigned this May 29, 2019
@medikoo medikoo marked this pull request as ready for review May 29, 2019 12:14
@medikoo medikoo requested a review from pmuens May 29, 2019 12:14
@medikoo medikoo mentioned this pull request May 29, 2019
@medikoo medikoo added this to the 1.45.0 milestone May 29, 2019
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@medikoo medikoo merged commit 0dff21e into master May 29, 2019
@pmuens pmuens deleted the fix-eslint-config branch May 30, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants