-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IAM policies setup for functions with custom name #6240
Conversation
@medikoo It'd also be good to extract these policies into managed policies to avoid #6212 from reoccurring when someone has a lot of functions with custom names. There is a default limit (1500) for customer managed policies, but that's a limit that can be changed unlike the user/role/group combined inline policy size. |
Yes, it probably can be next step (it also might have been discussed already). Still here we're just fixing the improvement made for functions with default names -> #6236. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any issues with this fix. LG2M. 👍
Fixes #6236
It appears that #6212 handled only function names as resolved when no
name
is provided.This patch ensure that proper polices are also created for functions with custom
name
Is this ready for review?: YES
Is it a breaking change?: NO