Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IAM policies setup for functions with custom name #6240

Merged
merged 10 commits into from
Jun 12, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 12, 2019

Fixes #6236

It appears that #6212 handled only function names as resolved when no name is provided.
This patch ensure that proper polices are also created for functions with custom name

Is this ready for review?: YES
Is it a breaking change?: NO

@weeniearms
Copy link
Contributor

weeniearms commented Jun 12, 2019

@medikoo It'd also be good to extract these policies into managed policies to avoid #6212 from reoccurring when someone has a lot of functions with custom names. There is a default limit (1500) for customer managed policies, but that's a limit that can be changed unlike the user/role/group combined inline policy size.

@medikoo
Copy link
Contributor Author

medikoo commented Jun 12, 2019

It'd also be good to extract these policies into managed policies

Yes, it probably can be next step (it also might have been discussed already). Still here we're just fixing the improvement made for functions with default names -> #6236.

eahefnawy
eahefnawy previously approved these changes Jun 12, 2019
Copy link
Member

@eahefnawy eahefnawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any issues with this fix. LG2M. 👍

@medikoo medikoo merged commit f0b3d9f into master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants