Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async leaks detection conditional #6319

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix async leaks detection conditional #6319

merged 1 commit into from
Jul 1, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 28, 2019 •
edited
Loading

Original detection just picked v8 and v9, this patch fixes that

Is this ready for review?: YES
Is it a breaking change?: NO

@medikoo
Fix Node.js version detection
49afdb5 
Original detection just picked v8 and v9
@medikoo medikoo added this to the 1.47.0 milestone Jun 28, 2019
@medikoo medikoo self-assigned this Jun 28, 2019
@medikoo medikoo requested a review from pmuens June 28, 2019 13:36
pmuens
pmuens approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@medikoo medikoo merged commit 015c4dc into master Jul 1, 2019
@medikoo medikoo deleted the fix-async-leaks-setup branch July 1, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

Assignees

@medikoo medikoo

Labels
tests
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@medikoo @pmuens