Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async leaks detection conditional #6319

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
2 participants
@medikoo
Copy link
Member

commented Jun 28, 2019

Original detection just picked v8 and v9, this patch fixes that

Is this ready for review?: YES
Is it a breaking change?: NO

Fix Node.js version detection
Original detection just picked v8 and v9

@medikoo medikoo added this to the 1.47.0 milestone Jun 28, 2019

@medikoo medikoo self-assigned this Jun 28, 2019

@medikoo medikoo added this to In progress in Serverless via automation Jun 28, 2019

@medikoo medikoo added pr/in-review and removed pr/in-progress labels Jun 28, 2019

@medikoo medikoo requested a review from pmuens Jun 28, 2019

@pmuens

pmuens approved these changes Jul 1, 2019

Copy link
Member

left a comment

LGTM :shipit:

Serverless automation moved this from In progress to Reviewer approved Jul 1, 2019

@medikoo medikoo merged commit 015c4dc into master Jul 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (medikoo) No manifest changes detected

Serverless automation moved this from Reviewer approved to Done Jul 1, 2019

@medikoo medikoo deleted the fix-async-leaks-setup branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.