S3 Block Public Access #6779
Merged
S3 Block Public Access #6779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a new boolean property named `blockPublicAccess`to the `deploymentBucket` config object for the AWS provider. * The property defaults to `false` to retain backwords compatibility with existing infrastructure. * When `true`, the configuration property will enable the [S3 Block Public Access][1]. This will prevent all future policies or ACLs that may grant public access to the deployment bucket. * Update the serverless.yml reference docs to reflect the addition. [1]: https://aws.amazon.com/blogs/aws/amazon-s3-block-public-access-another-layer-of-protection-for-your-accounts-and-buckets/ resolves: #6706
pmuens
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Good stuff! Thanks for working on this @jessedoyle 👍
I just tested it and it works as expected 💯 LGTM 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement
blockPublicAccessto thedeploymentBucketconfig object for the AWS provider.falseto retain backwordscompatibility with existing infrastructure.
true, the configuration property will enable theS3 Block Public Access feature. This will prevent all future
policies or ACLs that may grant public access to the
deployment bucket.
addition.
Closes #6706
How can we verify it
Add
blockPublicAccess: trueto thedeploymentBucketconfiguration object, then deploy.Ensure that the resulting CF template has the following properties in the
ServerlessDeploymentBucketresource:{ "PublicAccessBlockConfiguration": { "BlockPublicAcls": true, "BlockPublicPolicy": true, "IgnorePublicAcls": true, "RestrictPublicBuckets": true } }Is this ready for review?: Yes
Is it a breaking change?: No