Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace toString #7893

Merged
merged 1 commit into from Jun 30, 2020
Merged

Replace toString #7893

merged 1 commit into from Jun 30, 2020

Conversation

anhdevit
Copy link
Contributor

@anhdevit anhdevit commented Jun 30, 2020

Addresses #7747
@medikoo Hello, sorry for previous PR. I closed previous PR. Could you check for me?

@codecov-commenter
Copy link

Codecov Report

Merging #7893 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7893   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files         244      244           
  Lines        9057     9057           
=======================================
  Hits         8010     8010           
  Misses       1047     1047           
Impacted Files Coverage Δ
lib/plugins/aws/deployFunction/index.js 90.35% <100.00%> (ø)
lib/plugins/aws/package/compile/functions/index.js 97.05% <100.00%> (+0.01%) ⬆️
lib/plugins/create/create.js 90.69% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3062d...4b9f2d1. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @anhdevit Thank you!

@medikoo medikoo merged commit 028e467 into serverless:master Jun 30, 2020
@exoego exoego mentioned this pull request Jun 30, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants