Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI Onboarding): Remove tab-completion from interactive flow #9531

Merged
merged 1 commit into from May 31, 2021

Conversation

pgrzesik
Copy link
Contributor

Addresses: #9367

@pgrzesik pgrzesik self-assigned this May 31, 2021
@pgrzesik pgrzesik added cat/cli-onboarding Interactive CLI onboarding enhancement labels May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #9531 (5805352) into master (d5e2baf) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9531      +/-   ##
==========================================
- Coverage   86.75%   86.71%   -0.04%     
==========================================
  Files         322      321       -1     
  Lines       12100    12064      -36     
==========================================
- Hits        10497    10461      -36     
  Misses       1603     1603              
Impacted Files Coverage Δ
lib/cli/interactive-setup/index.js 100.00% <ø> (ø)
.../tabCompletion/promptDisabledConfigPropertyName.js 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e2baf...5805352. Read the comment docs.

@pgrzesik pgrzesik requested a review from medikoo May 31, 2021 08:53
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

For history, main reason is that while some of the users are relying on it, this feature doesn't work well. Due to long serverless startup time, it's slow, so there's no reason to promote it.

Once we fix serverless startup time, we may revisit this

@pgrzesik pgrzesik merged commit 3bac0f3 into master May 31, 2021
@pgrzesik pgrzesik deleted the adjust-autoupdate-and-autocomplete-steps branch May 31, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/cli-onboarding Interactive CLI onboarding enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants