Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI Onboarding): Remove tab-completion from interactive flow #9531

Merged
merged 1 commit into from May 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/cli/interactive-setup/index.js
Expand Up @@ -8,7 +8,6 @@ const steps = {
dashboardSetOrg: require('@serverless/dashboard-plugin/lib/cli/interactive-setup/dashboard-set-org'),
awsCredentials: require('./aws-credentials'),
autoUpdate: require('./auto-update'),
tabCompletion: require('./tab-completion'),
};

module.exports = async (context) => {
Expand Down
64 changes: 0 additions & 64 deletions lib/cli/interactive-setup/tab-completion.js

This file was deleted.

10 changes: 0 additions & 10 deletions test/unit/lib/cli/interactive-setup/index.test.js
Expand Up @@ -4,7 +4,6 @@

const spawn = require('child-process-ext/spawn');
const path = require('path');
const isTabCompletionSupported = require('../../../../../lib/utils/tabCompletion/isSupported');

const serverlessPath = path.resolve(__dirname, '../../../../../scripts/serverless.js');
const templatesPath = path.resolve(__dirname, '../../../../../lib/plugins/create/templates');
Expand Down Expand Up @@ -55,15 +54,6 @@ describe('test/unit/lib/cli/interactive-setup/index.test.js', () => {

// auto-update
{ instructionString: 'to update automatically?', input: 'Y' },

// tab-completion
...(isTabCompletionSupported
? [
{ instructionString: 'command line <tab> completion', input: 'Y' },
{ instructionString: 'bash' },
{ instructionString: 'to ~/.bashrc' },
]
: []),
];
slsProcess.stdout.on('data', (data) => {
output += data;
Expand Down
73 changes: 0 additions & 73 deletions test/unit/lib/cli/interactive-setup/tab-completion.test.js

This file was deleted.