refactor(*): add iso8601duration validate tag #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The #76 should be merge before, it will fix |
ricardozanini
approved these changes
Sep 23, 2022
spolti
reviewed
Sep 23, 2022
| @@ -94,7 +101,7 @@ func TestRetryStructLevelValidation(t *testing.T) { | |||
| Increment: "PT5S", | |||
| Jitter: floatstr.FromString("P5S"), | |||
| }, | |||
| err: `Key: 'Retry.Jitter' Error:Field validation for 'Jitter' failed on the 'reqiso8601duration' tag`, | |||
| err: `Key: 'Retry.Jitter' Error:Field validation for 'Jitter' failed on the 'iso8601duration' tag`, | |||
There was a problem hiding this comment.
this message is coming from the validateFunc, right?
Do you think we can make this message easier to understand?
Something like "field is not iso8601duration"
There was a problem hiding this comment.
Yes, we should custom the error message to have more description, and this should be done later. For how to implement custom error message, maybe go-playground/validator#559 will helpful.
Signed-off-by: lsytj0413 <511121939@qq.com>
|
@ricardozanini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lsytj0413 511121939@qq.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):