-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(*): validate stateExecTimeout iso8601 #76
fix(*): validate stateExecTimeout iso8601 #76
Conversation
@lsytj0413 see here: https://github.com/lsytj0413/swf-sdk-go/pull/1 I'm still failing to understand when the recursion occurs. |
unmarshalJSON1 is previous version implement, and i think unmarshalJSON2(secondary version implement) is more concise:
|
the recursion occurs when:
so we must use another type which didn't implement json.Unmarshaler interface for step 2. |
send me a workflow to include in the unit test, please. |
I have change PR to secondary implement with all unit test. |
Looking good! |
Signed-off-by: lsytj0413 <511121939@qq.com>
Signed-off-by: lsytj0413 511121939@qq.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):