Some Linting #17
Closed
Some Linting #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case I would suggest also running the tests yourself with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a mater of precaution I like to run pylint on codebases before I use them. This rated O.K. in its current state, like a 7 or something. Though I hand review all the pylint notices and there are still some things in this code base that scare the pants off me.
Some things I'm unsure of are the
valve.source.messages,MessageArrayFieldmethods that return a locally defined function. These all use potentially dangerous constructors and I am unsure if they are being abused to a greater effect so I mostly left that alone.I am mostly posting this pull request to see if the travis CI tests work, hopefully letting me know if I messed up any functionality.