-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make card sizes uniform on the site #291
Comments
can I work on this @debo19 |
Go, @AnshumanDhiman, go! - your personal cheerleader. |
Thank you lee 😃 |
@debo19 I need some help, the cards created are kind off hooked, like there is template for 1 card in the code and we are using it to derive other cards from the same code. |
@AnshumanDhiman Separating each card will make the code redundant, we will have more posts added in eventually. 🤔 Did you try giving the cards a min-height? We'll probably have to use same sized images and subtitles to make them have similar sizes in this case. Also, we can try aligning the cards vertically to the bottom of the row, then the green part may look aligned. |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
Any updates on the issue @AnshumanDhiman ? |
@Nikhil-Ladha I am facing issues with refactoring the cards as they all are linked together with a single one like passed on as a prop. As every card has different image dimensions so to customize every card, we have to create each card manually which will increase the code. If anyone can take this issue with a different approach, it will be helpful. |
Thanks for the heads-up @AnshumanDhiman . Let's see if anyone has other ideas. |
Can you please assign me this issue under Openforce |
Go ahead @Atif0604 |
Hi, I am Nikunj Rohit, a contributor to OpenForce 2022. If this issue is still open I would like to work on this issue and try better to enhance it more. I would be making a PR as soon as I am done with resolving the issue. Thank you |
Can I work on this issue @debo19 |
@St80ene volunteered to take a look in the last websites call iirc. Were you successful here? If you're not working on this currently, we can pass on the assignment |
@Akshit42-hue can handle it if possible since he indicated before me. Although, I was just taking some time to study the code. But it's cool. |
@Akshit42-hue will you be taking this forward from here? |
Sure, I will @debo19 |
if the issue is solved pls close it. |
Description
Expected Behavior
Screenshots
Environment:
[Optional] To Reproduce
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: