-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made Uniform Card Size #307
base: master
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for smp-spec ready! 🔨 Explore the source changes: a0836b8 🔍 Inspect the deploy log: https://app.netlify.com/sites/smp-spec/deploys/622eb3f01670920008723a35 😎 Browse the preview: https://deploy-preview-307--smp-spec.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Atif0604 Thank you for looking into this, could you please squash these commits or create a new PR for this? 18 commits is too much for a small change.
A couple of things:
- The aspect ratio needs to be maintained, the images here are getting skewed.
I agree with @warunicorn19 you should squash changes once you are done and possibly a better commit message. Nothing too fancy just like Adjusted Card Size or Card Position something of that sort. https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git This is a great link to get to know how to squash commits |
Done
Done @warunicorn19 |
@Atif0604 Available to discuss this on the websites call tomorrow? |
Okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Atif0604 the cards are not of uniform size yet. I hope you understand what the issue is. If not, please do clarify.
@Atif0604 Let's convert this PR into a draft if you're still looking for a way. Ping when you find a solution. Meanwhile we can unassign you from the issue so that any other contributor can jump in and help us out here :) |
Description
This PR fixes #291
Notes for Reviewers
Signed commits