Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Uniform Card Size #307

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Atif0604
Copy link

@Atif0604 Atif0604 commented Mar 7, 2022

Description

This PR fixes #291

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for smp-spec ready!

🔨 Explore the source changes: a0836b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/smp-spec/deploys/622eb3f01670920008723a35

😎 Browse the preview: https://deploy-preview-307--smp-spec.netlify.app/

@leecalcote leecalcote requested review from a team March 7, 2022 21:51
Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atif0604 Thank you for looking into this, could you please squash these commits or create a new PR for this? 18 commits is too much for a small change.
A couple of things:

  1. The aspect ratio needs to be maintained, the images here are getting skewed.

Screenshot 2022-03-07 at 7 58 50 PM

2. These cards also need to be aligned, as per issue description.

Screenshot 2022-03-07 at 7 59 12 PM

@warunicorn19 warunicorn19 added the openforce Issues marked for the OpenForce contest label Mar 8, 2022
@hershd23
Copy link

hershd23 commented Mar 9, 2022

I agree with @warunicorn19 you should squash changes once you are done and possibly a better commit message. Nothing too fancy just like Adjusted Card Size or Card Position something of that sort.

https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

This is a great link to get to know how to squash commits

@Atif0604
Copy link
Author

Atif0604 commented Mar 9, 2022

Done

I agree with @warunicorn19 you should squash changes once you are done and possibly a better commit message. Nothing too fancy just like Adjusted Card Size or Card Position something of that sort.

https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

This is a great link to get to know how to squash commits

Done @warunicorn19
and Thank you for helping @hershd23

@debo19
Copy link
Member

debo19 commented Mar 13, 2022

@Atif0604 Available to discuss this on the websites call tomorrow?

@Atif0604
Copy link
Author

@Atif0604 Available to discuss this on the websites call tomorrow?

Okay

Copy link
Member

@debo19 debo19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atif0604 the cards are not of uniform size yet. I hope you understand what the issue is. If not, please do clarify.

@Atif0604
Copy link
Author

@Atif0604 the cards are not of uniform size yet. I hope you understand what the issue is. If not, please do clarify.

Hey @debo19 i tried everything to make it uniform but other things(images) are getting affected

@debo19
Copy link
Member

debo19 commented Mar 20, 2022

@Atif0604 Let's convert this PR into a draft if you're still looking for a way. Ping when you find a solution. Meanwhile we can unassign you from the issue so that any other contributor can jump in and help us out here :)

@debo19 debo19 marked this pull request as draft March 20, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website openforce Issues marked for the OpenForce contest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make card sizes uniform on the site
7 participants