Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to cards #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnshumanDhiman
Copy link

@AnshumanDhiman AnshumanDhiman commented Jan 26, 2022

Signed-off-by: AnshumanDhiman 67755381+AnshumanDhiman@users.noreply.github.com

Description

This PR fixes #291

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: AnshumanDhiman <67755381+AnshumanDhiman@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for smp-spec ready!

🔨 Explore the source changes: b5ae3b7

🔍 Inspect the deploy log: https://app.netlify.com/sites/smp-spec/deploys/61f1b1337fddae0007256194

😎 Browse the preview: https://deploy-preview-303--smp-spec.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aspect ratio must be maintained
Screen Shot 2022-01-26 at 2 43 23 PM
.

@@ -15,3 +15,5 @@ group :jekyll_plugins do
# Delete the following lines if not on Windows:
# Performance-booster for watching directories on Windows
gem "wdm", ">= 0.1.0" if Gem.win_platform?

gem "webrick", "~> 1.7"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnshumanDhiman Could you please revert this change? Thanks for your contribution 🎉

Comment on lines +22 to 27
eventmachine (1.2.7-x64-mingw32)
execjs (2.7.0)
ffi (1.15.4)
ffi (1.15.4-x64-mingw32)
forwardable-extended (2.6.0)
gemoji (3.0.1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnshumanDhiman Could you please revert the changes to this file as well?

@leecalcote leecalcote added the issue/remind progress check label Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄 on the project.

@leecalcote
Copy link
Member

Merge conflicts...

@adithyaakrishna
Copy link

@AnshumanDhiman Any updates on this? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/remind progress check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make card sizes uniform on the site
3 participants