Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Fix typo in documentation #222

Closed
wants to merge 1 commit into from

Conversation

Alan-Cha
Copy link

No description provided.

Signed-off-by: Alan Cha <ac3805@columbia.edu>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in here, @Alan-Cha. This statement is slightly deceiving in that "weigh" as a verb makes intuitive sense, although, "weight" being used as a verb is actually appropriate.

The intended meaning here, is that implementations will allocate a certain amount of "weight" to traffic to determine their appropriate destination. I think this becomes much more clear when the word "assign" is added, like so: "Implementations will assign weight to outgoing traffic between the services referenced by..."

In lieu of this understanding, I'll suggest that we either close this PR or toss in the word "assign" for clarification.

Copy link
Contributor

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alan-Cha Would you like to update the PR based on Lee's suggestion?

#222 (review)

@bridgetkromhout
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants