Drop #[no_mangle] from cg_event_tap_callback_internal #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows multiple versions of core-graphics to be linked into the same binaries without getting "duplicate symbol: cg_event_tap_callback_internal"
|
Previously the only major version that included this symbol was 0.22 now that 0.23 also has it we're much more likely to get in trouble. |
|
@bors-servo r+ |
|
📌 Commit f3cf0f1 has been approved by |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows multiple versions of core-graphics to be linked into the same binaries without getting "duplicate symbol: cg_event_tap_callback_internal"