Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Add android support #15

Merged
merged 3 commits into from Aug 29, 2016
Merged

Add android support #15

merged 3 commits into from Aug 29, 2016

Conversation

dati91
Copy link
Contributor

@dati91 dati91 commented Aug 15, 2016

Add bluetooth android support with blurdroid crate.

Also I moved the unimplemented code to the empty.rs file.
And there is an API change (get_object_path -> get_id).


This change is Reviewable

@dati91
Copy link
Contributor Author

dati91 commented Aug 15, 2016

r? @jdm
And a question: this will break servo (because of the API change), or servo's lock file will save the day?

@dati91
Copy link
Contributor Author

dati91 commented Aug 15, 2016

Also this will solve #8 (at least i think so)

@dati91 dati91 force-pushed the refactor branch 4 times, most recently from 44a3319 to a7146cf Compare August 15, 2016 11:00
@jdm
Copy link
Member

jdm commented Aug 15, 2016

Servo's lock file will prevent Servo from using a more recent revision.

@zakorgy
Copy link
Contributor

zakorgy commented Aug 25, 2016

r? @jdm

@larsbergstrom
Copy link
Contributor

@jdm Will you have a chance to take a look at this before you go on PTO, or would you like me to do so?

@jdm
Copy link
Member

jdm commented Aug 25, 2016

@larsbergstrom If you could take a look at it, that would make my life easier.

@larsbergstrom larsbergstrom self-assigned this Aug 25, 2016
@larsbergstrom
Copy link
Contributor

The code looks mostly fine to me! The only question I have is whether it works when you are compiling with target_os=linux but without feature=bluetooth enabled? It looks like there were a bunch more #cfg branches added in the first commit that fill out the non-linux side of things but that leaves linux-minus-bluetooth-feature, unless I'm misunderstanding and you expect those files not to be compiled at all.

@dati91
Copy link
Contributor Author

dati91 commented Aug 29, 2016

Yeah you are right, I didn't handled the case when we turn the bluetooth feature off! I hope now everything is fine.

@larsbergstrom
Copy link
Contributor

lgtm! Do you mind squashing it into more logical commits, and then we can land it? Thanks!

@larsbergstrom
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link

📌 Commit fe1393d has been approved by larsbergstrom

@bors-servo
Copy link

⚡ Test exempted - status

@bors-servo bors-servo merged commit fe1393d into servo:master Aug 29, 2016
bors-servo pushed a commit that referenced this pull request Aug 29, 2016
Add android support

Add bluetooth android support with [blurdroid](https://crates.io/crates/blurdroid) crate.

Also I moved the unimplemented code to the `empty.rs` file.
And there is an API change (`get_object_path -> get_id`).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/devices/15)
<!-- Reviewable:end -->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants