New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange Arc<Vec<u8>> for Arc<Cow<'a, [u8]>> #46

Open

fschutt wants to merge 2 commits into servo:main from fschutt:master

fschutt commented Jan 28, 2021

This way users do not have to allocate the font if the font data is included in the binary. See servo/webrender#4233

fschutt added 2 commits

January 28, 2021 19:54


          Exchange Arc<Vec<u8>> for Arc<Cow<'a, [u8]>>

065248f

Avoids allocation in case the font is embedded in the binary
file as a &'static [u8]


          Update version number due to breaking API change

7ca1b79

fschutt mentioned this pull request

Use Cow<'static, [u8]> for FontData instead of Vec<u8> servo/webrender#4234

Closed

Member

jdm commented Mar 29, 2021

error[E0308]: mismatched types
  --> src\test.rs:95:53
   |
95 |     let new_font = FontFile::new_from_data(Arc::new(bytes));
   |                                                     ^^^^^ expected enum `Cow`, found struct `Vec`
   |
   = note: expected enum `Cow<'_, [u8]>`
            found struct `Vec<u8>`
error: aborting due to previous error; 2 warnings emitted

Otherwise these changes look fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment