Allow euclid to be built in no_std environments #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r=kvark |
|
📌 Commit a462d6a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 4, 2018
Allow euclid to be built in no_std environments (blocked on #279, since only `num-traits` > 0.2 is `no_std` compatible) Since this crate does not use any `std`-specific features, this pull request makes it `no_std`. The tests are still built and run using `std`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/289) <!-- Reviewable:end -->
|
Sorry, overlooked that it depends on another PR. |
|
☀️ Test successful - status-travis |
|
It should be alright, it works and the tests pass but it won't be usable in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(blocked on #279, since only
num-traits> 0.2 isno_stdcompatible)Since this crate does not use any
std-specific features, this pull request makes itno_std.The tests are still built and run using
std.This change is