This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Update from upstream #107
Merged
Update from upstream #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis: Enabled deps cache
README.md: docs.io -> docs.rs
…teWindow Properly create a wide string for use in the call to CreateWindowExW
|
Or @glennw, if you know how we usually update glutin :-) |
|
Yeah, we usually merge. @bors-servo: r+ |
|
📌 Commit 5e9bef3 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Oct 6, 2016
Update from upstream r? @metajack @emilio Do we normal do these updates as a `git merge tomaka/glutin` and then open the PR with a merge commit? Or do we rebase our branch on top of it and then do a yolo-force-push onto the servo branch? /me is confused... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/107) <!-- Reviewable:end -->
|
Great - thanks a ton! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @metajack @emilio
Do we normal do these updates as a
git merge tomaka/glutinand then open the PR with a merge commit? Or do we rebase our branch on top of it and then do a yolo-force-push onto the servo branch? /me is confused...This change is