This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
linux: Disable Wayland backend because it's unusable for Servo. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context, Gnome has switched to wayland by default in a few distros, including Arch and Fedora 25, so I expect more people trying Servo with wayland. It's kind of unfortunate to see a huge stack trace a few milliseconds after starting. cc @metajack too, I guess. |
|
@bors-servo r+ |
|
📌 Commit ac8b2c1 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Oct 13, 2016
linux: Disable Wayland backend because it's unusable for Servo. r? @larsbergstrom or @glennw or @pcwalton Funny how that comment was there but was completely ignored. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/108) <!-- Reviewable:end -->
|
More context here: rust-windowing#814 |
bors-servo
pushed a commit
that referenced
this pull request
Feb 2, 2017
Remove wayland support and dependencies Our glutin fork has diverged significantly from upstream, and it will take significant work to merge them, or to move to some new windowing API built on top of glutin, winit, or otherwise. In the meantime we are building very old Wayland libraries but never using them (#108). As a short-term patch to improve Servo build times by not building a bunch of unused dependencies, this patch just rips out the unused wayland support from our fork. (This code is already gone from upstream glutin, moved into `winit` and using newer, rewritten wayland crates.) r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/115) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @larsbergstrom or @glennw or @pcwalton
Funny how that comment was there but was completely ignored.
This change is