Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Upgrade some libraries #54

Closed
wants to merge 3 commits into from
Closed

Upgrade some libraries #54

wants to merge 3 commits into from

Conversation

SimonSapin
Copy link
Member

Review on Reviewable

antrik and others added 2 commits November 30, 2015 09:13
@antrik
Fix compilation for 32 bit targets
32ed86a 
Regression introduced in 47df0e9

Casting fullscreen_atom (which is the result from XInternAtom, i.e.
c_ulong) as i64 is obviously wrong -- the whole point of types such as
c_ulong is that long in C does *not* always have the same bit size...

Cast it as c_long instead.

While this is the most straightforward fix, I'm not sure it's the best
one: perhaps the x11 crate should offer a set_ulong() method along with
set_long(), which could be used here instead of the cast?
@tomaka
Merge pull request rust-windowing#665 from antrik/fix-cast_32bit-upst…
5b819ed 
…ream

Fix compilation for 32 bit targets
@SimonSapin
Copy link
Member Author

@bors-servo r+

@bors-servo
Copy link

📌 Commit a48cabc has been approved by SimonSapin

@bors-servo
Copy link

⌛ Testing commit a48cabc with merge dd9ebc3...

bors-servo pushed a commit that referenced this pull request Nov 30, 2015
Auto merge of #54 - servo:libs, r=SimonSapin
dd9ebc3 
Upgrade some libraries

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/glutin/54)
<!-- Reviewable:end -->
@bors-servo
Copy link

💔 Test failed - travis

@SimonSapin SimonSapin closed this Dec 1, 2015
@SimonSapin
Copy link
Member Author

Moved to #55.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimonSapin @bors-servo @antrik @tomaka