This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Merge from glutin upstream #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency fix
Fix EGL for wayland.
Per http://linux.die.net/man/3/xiquerydevice: > XIFreeDeviceInfo frees the information returned by > XIQueryDevice.
Fix wrong screen ID used on GLX
x11: Prevent leak on XIQueryDevice
According to https://msdn.microsoft.com/en-us/library/windows/desktop/dd318284(v=vs.85).aspx if double buffer is unavailable then a single buffer will be returned
Prefer double buffer on wgl if unspecified
Fixes rust-windowing#697 It seems that `XSync` doesn't really makes the window viewable. This feels hacky, other option to do it could be using `XIfEvent` or similar to listen to `MapNotify` events, but we'll have a loop still. In practice, this lasts between two and thre iterations on my machine, which is something not noticeable.
x11: Poll the window until it is really visible
This includes rust-windowing#706, which should allow the landing of the glutin update.
|
r? @SimonSapin |
|
@bors-servo r+ |
|
Not sure what’s happening with homu, but the Travis build for this PR is green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow landing the glutinup into servo now rust-windowing#706 has landed fixing rust-windowing#697.