This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
cocoa: Activate the NSApplication instance after the event loop is set up, and use orderFrontRegardless to more reliably pop up the main window.
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs servo/cocoa-rs#132 |
pcwalton
force-pushed
the
mac-proper-activation
branch
from
560bfb0
to
56a9c63
Compare
up, and use `orderFrontRegardless` to more reliably pop up the main window. This makes the menus work right away when the app is started. See e.g. http://czak.pl/2015/09/23/single-file-cocoa-app-with-swift.html
|
@bors-servo r+
|
|
📌 Commit 56a9c63 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 11, 2016
cocoa: Activate the `NSApplication` instance after the event loop is set up, and use `orderFrontRegardless` to more reliably pop up the main window. This makes the menus work right away when the app is started. See e.g. http://czak.pl/2015/09/23/single-file-cocoa-app-with-swift.html r? @metajack <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/96) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the menus work right away when the app is started.
See e.g. http://czak.pl/2015/09/23/single-file-cocoa-app-with-swift.html
r? @metajack
This change is