This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
return coordinates in MouseInput events #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmiywj
force-pushed
the
return-coordinates-in-MouseInput
branch
from
fa78c11
to
57e9758
Compare
|
@paulrouget -reply |
| Some(MouseInput(Released, MouseButton::Right, | ||
| Some(((scale_factor * window_point.x as f32) as i32, | ||
| (scale_factor * window_point.y as f32) as i32)))) | ||
| }, |
There was a problem hiding this comment.
Any idea how to avoid repeating this code block?
There was a problem hiding this comment.
Yeah, actually I want to write this code block into a function, but I'm not sure what struct it should be implemented in.
There was a problem hiding this comment.
You could just make it a private function inside this module, or even inside this method.
mrmiywj
force-pushed
the
return-coordinates-in-MouseInput
branch
from
57e9758
to
8708616
Compare
|
@paulrouget I've refactored it. |
|
@bors-servo r+ |
|
📌 Commit 8708616 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 16, 2016
return coordinates in MouseInput events Return mouse coordinates in MouseInput event. Due to this [servo issue](servo/servo#11130) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/97) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
This was referenced Jun 19, 2016
bors-servo
pushed a commit
that referenced
this pull request
Jun 25, 2016
…aulroget fix return coordinates in MouseInput It is a fix of #97 When working on [servo/#11794](servo/servo#11794). I found the previous PR #97 is wrong. This PR is a fix of that and is right when testing [servo/#11794](servo/servo#11794). Actually, we should return the mouse movement position instead of actual coordination. So the previous PR's return value is wrong. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/99) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Jan 22, 2017
…pcwalton return coordinates in MouseWheel events Glutin side of servo/servo#14808 to fix servo/servo#14290, it's a follow up from #97 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/109) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return mouse coordinates in MouseInput event.
Due to this servo issue
This change is